tinyproxy and brazilfw 2.30.1 [closed - fixed] [INACTIVE]

[bobbb]

A fresh floppy create with 2.30.1 does not put these two line in the coyote.cfg whereas 2.30 does

Código: Selecionar todos

LOCAL_BROADCAST='192.168.0.255'
LOCAL_NETWORK='192.168.0.0'

This causes tinyproxy to fail.
viewtopic.php?f=3&t=63961

[Marcos do Vale]

In BrazilFW 2.30 Service Pack 1 Released (viewtopic.php?f=5&t=61492)

...
Fixed Bugs:
...
- Removed broadcast and network parameters (Thanks to caeduoliveira and others)
viewtopic.php?t=60610
...

[bobbb]

Ok then tinyproxy needs to be fixed to include the following so that it may continue to work with 2.30.1 and above.

Código: Selecionar todos

eval `ipcalc -p ${LOCAL_IPADDR} ${LOCAL_NETMASK}`
eval `ipcalc -n ${LOCAL_IPADDR} ${LOCAL_NETMASK}`
echo "Allow  ${NETWORK}/${PREFIX}" >> /etc/tinyproxy/tinyproxy.conf


instead of

Código: Selecionar todos

eval `ipcalc -p ${LOCAL_NETWORK} ${LOCAL_NETMASK}`
echo "Allow  ${LOCAL_NETWORK}/${PREFIX}" >> /etc/tinyproxy/tinyproxy.conf

I have prepared this patch and uploaded it to my area but I think it should replace the entry in the addon directory.
I see that someone else has a fix for tinyproxy and has a new binary dated Jan 2008. I have incorporated that in my patch.

Changed the title of this thread.

[Claudio]

That's right, these parameters were removed from config file since BrazilFW 2.30.1.

It was because some users used to change their ip and/or mask and but let network and broadcast unchanged, then those users got a few unpredictable erros. As they can be easily calculated i thought better just to remove the parameters. At that time i checked all BrazilFW scripts looking for references to these parameters, but i did not check all the add-ons.

To add the parameters to coyote.conf will not solve this problem, if the users change anything on webadmin they will be removed again. You done right adding the calculation to the add-on scripts.

I could not find an entry for tinyproxy on add-ons index. Could you please write one?

[bobbb]

Agreed on the changes. Dynamic calculation is better.

I'll change the thread about adding those lines.

There seems to be 3 places where tinyproxy is loacted in the forums. In the original addons, in dshanks userspace January 2008 and now in mine. I included the fixed binary from January 2008 in my patch.

I'll write a summary for tinyproxy but wonder if it should be in my area or in the original area.

[Claudio]

I'll write a summary for tinyproxy but wonder if it should be in my area or in the original area.

Actually, i think it doesn't matter. Since the add-ons index point to the right place.

Since you appear to have adopted these orfan add-on, i think it's better to leave it inside your place. Then i will delete the old one on the general folder to avoid any confusion.

[bobbb]

adopted??

Ok it's done.