BFW 2.26.0 QOS Function BUG [INACTIVE]

[sabitsoftware]

Hi Claudio,

I think that there is a bug in the new BFW v 2.26.0 - QOS subsystem.

To be more precise :
- in the rc.qos.coyote file;
- inside define_class_base_qos() function;
- line
"$TC class add dev $IF_LOCAL parent ${2} classid 1:$slow_cls_id htb prio 1 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k
" is wrong

The above line should look like this one:

"$TC class add dev $IF_LOCAL parent ${1} classid 1:$slow_cls_id htb prio 1 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k"

Otherwise the SLOW_PRI class it is attached to the root and not to 1:10 class.

This bug appears only on "define_class_qos" configurations

[Claudio]

Noted.

Thank You.

[babayaga]

So we should manualy change it? Or wait for a update?

[Claudio]

You should change, of course.

[filo]

Hello,
I'm not familiar with Linux and QoS enough, so that maybe I'm wrong, but ...
If for DOWNSTREAM section line 50
$TC class add dev $IF_LOCAL parent ${2} classid 1:$slow_cls_id htb prio 1 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k
must be changed to
$TC class add dev $IF_LOCAL parent ${1} classid 1:$slow_cls_id htb prio 1 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k

then for UPSTREAM section this line 68 is OK ?
$TC class add dev $IF_INET parent ${2} classid 1:$slow_cls_id htb prio 1 rate ${UP_SLOW_PRI}kbit ceil ${5}kbit burst ${QOS_SUP_BURST}k
or must be changed to
$TC class add dev $IF_INET parent ${1} classid 1:$slow_cls_id htb prio 1 rate ${UP_SLOW_PRI}kbit ceil ${5}kbit burst ${QOS_SUP_BURST}k ?

Thanks for answer.
Filo

[sabitsoftware]

Hello,
I'm not familiar with Linux and QoS enough, so that maybe I'm wrong, but ...
If for DOWNSTREAM section line 50
$TC class add dev $IF_LOCAL parent ${2} classid 1:$slow_cls_id htb prio 1 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k
must be changed to
$TC class add dev $IF_LOCAL parent ${1} classid 1:$slow_cls_id htb prio 1 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k

then for UPSTREAM section this line 68 is OK ?
$TC class add dev $IF_INET parent ${2} classid 1:$slow_cls_id htb prio 1 rate ${UP_SLOW_PRI}kbit ceil ${5}kbit burst ${QOS_SUP_BURST}k
or must be changed to
$TC class add dev $IF_INET parent ${1} classid 1:$slow_cls_id htb prio 1 rate ${UP_SLOW_PRI}kbit ceil ${5}kbit burst ${QOS_SUP_BURST}k ?

Thanks for answer.
Filo

Hi Filo

you are right
also the upstream section must be changed

[filo]

Hi Filo
you are right
also the upstream section must be changed

Thanks for ultraquick reaction, bye ;)

[Claudio]

I'm afraid i can miss some little fix.

Can you send me the final version?

[Jenya]

Hi Claudio,
are these little fixies included in BrazilFW 2.29.4?
Thanx for answer

[Claudio]

Yes. Those thing might be fixed. Can you check that?

[Jenya]

I found this:
Above considered as right is:
$TC class add dev $IF_LOCAL parent ${1} classid 1:$slow_cls_id htb prio 1 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k

but in the BrazilFW 2.29.4 script is:
$TC class add dev $IF_LOCAL parent ${1} classid 1:$slow_cls_id htb prio 2 rate ${DOWN_SLOW_PRI}kbit ceil ${3}kbit burst ${QOS_SDOWN_BURST}k

I don`t understand much Qos scripts but hope it`s right.

[Claudio]

Yes, it should be 2.

That other bug which i have fixed.